Add variational neural network solver - #43
Merged
Conversation
ohno
marked this pull request as ready for review
August 11, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VariationalNeuralNetworkwith theVNNabbreviationarchitectureand arbitrary user-supplied Lux modelsWhy
This implements the neural-network trial wavefunction proof of concept proposed in #33 while keeping the FDM discretization as the shared numerical backend. The convenience API covers the common case, while the explicit-model API allows users to experiment with custom Lux architectures and trial envelopes.
User impact
Users can now write either:
or pass an arbitrary Lux model:
The result includes the variational energy, normalized grid wavefunction, callable wavefunction, training history, Lux state, and optimizer state.
Validation
git diff --checkpassedThe full local documentation site was not completed because the shared host Julia cache repeatedly stalled while precompiling CairoMakie; the VNN page itself builds cleanly without warnings.
Closes #33
This pull request was developed with assistance from Codex using GPT-5.6 Sol with High reasoning effort.